Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix streaming batch #1074

Merged
merged 3 commits into from
May 22, 2023
Merged

fix streaming batch #1074

merged 3 commits into from
May 22, 2023

Conversation

johny-b
Copy link
Contributor

@johny-b johny-b commented Dec 15, 2022

No description provided.

@johny-b johny-b requested a review from a team December 15, 2022 11:53
@johny-b johny-b mentioned this pull request Dec 15, 2022
@shadeofblue
Copy link
Contributor

@johny-b it'd be useful to have some context in this pull request

@johny-b
Copy link
Contributor Author

johny-b commented Dec 20, 2022

@johny-b it'd be useful to have some context in this pull request

Well, it was a response to the linked PR by @prekucki :)

But the general context is: streaming API doesn't work now. This fixes it (and also demonstrates the change on the blender example, OFC there's no reason to merge the changed blender).

@shadeofblue shadeofblue self-requested a review December 22, 2022 12:47
@shadeofblue shadeofblue merged commit 3573e7f into master May 22, 2023
@shadeofblue shadeofblue deleted the jb/stdout branch May 22, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants